Add excel.sheet formatting contract for WranglesXL - #1136
Conversation
|
@ebhills I did few changes: Renamed number_format → num_format in _FORMATTING_OPTIONS, the validation branch, and its error message. Updated test_excel_sheet_write_preserves_column_formatting to use num_format instead of number_format. |
|
@mborodii-prog - one more formatting option that we need in this first go is text wrap. Can you please add it too? |
|
@ebhills Added text_wrap as a new boolean formatting option, with tests passing |
f027d6d to
e732925
Compare
|
@ebhills this PR is tested in DEV, also opened aditional PR for XL to support num_format and text_wrap. To test it by own in DEv you can use image dev-1.20.0rc56 in execute-recipe-dev. As for me we're good to go agead with that PR: write:
''' |


Closes #1135
Paired client implementation: https://github.com/wrangleworks/WranglesXL/pull/1199
Related client issue: https://github.com/wrangleworks/WranglesXL/issues/1198
Summary
formatting.columnscontract toexcel.sheetalign,number_format,bold, andcheckboxBehavior and compatibility
Recipes without
formattingare unchanged. Matching batched writes still combine into one dataframe payload. A formatting change for the same sheet and cell starts a new payload segment so rows retain their original order and formatting intent.This changes only
excel.sheet; the file connector formatting behavior is unaffected.Validation
.venv\\Scripts\\python.exe -m pytest tests\\connectors\\test_excel.py: 11 passedgit diff --check origin/main...HEAD: passedRollback
Revert commit
4ae4e107to remove the new contract and restore the previous aggregation behavior.