Skip to content

Expand generic dispatch differential fuzz coverage #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frotty merged 2 commits into from
Aug 30, 2026
Merged

Expand generic dispatch differential fuzz coverage #1275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d69638
Expand generic dispatch differential fuzz coverage
Frotty Aug 30, 2026
21fbe5a
Randomize required dispatch fuzz shapes
Frotty Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 39 additions & 10 deletions de.peeeq.wurstscript/src/test/java/tests/wurstscript/tests/LuaBackendAuditTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.EnumSet;
import java.util.List;
import java.util.Random;

Expand Down Expand Up @@ -1544,7 +1545,10 @@ public void randomizedClassInterfaceModuleDispatchMatchesAllBackends() {
public void randomizedGenericTupleDispatchMatchesJassAndLua() {
Random random = new Random(0x71A9D15CL);
for (int caseIndex = 0; caseIndex < 8; caseIndex++) {
List<String> source = genericTupleDispatchCase(random, caseIndex);
EnumSet<GenericDispatchShape> covered = EnumSet.noneOf(GenericDispatchShape.class);
List<String> source = genericTupleDispatchCase(random, covered);
assertEquals("dispatch fuzz case must cover every semantic specialization shape",
EnumSet.allOf(GenericDispatchShape.class), covered);
String[] lines = source.toArray(new String[0]);
try {
test().executeProg().lines(lines);
Expand All @@ -1565,6 +1569,17 @@ public void randomizedGenericTupleDispatchMatchesJassAndLua() {
}
}

private enum GenericDispatchShape {
TUPLE_INT,
TUPLE_TEXT,
NESTED_TUPLE_INT,
NESTED_TUPLE_TEXT,
CLASS_PREDICATE,
OTHER_CLASS_PREDICATE,
OTHER_CLASS_PREDICATE_SECOND_TYPE,
CLASS_IMPLEMENTATION
}

/** A user method beginning with {@code destroy} is ordinary virtual dispatch, not lifecycle
* destruction. The lifecycle slot is identified from the generated OnDestroy function. */
@Test
Expand Down Expand Up @@ -1592,7 +1607,8 @@ public void ordinaryDestroyNamedMethodDoesNotUseLifecycleDispatchSlot() throws I
assertFalse(dispatchBody.contains(".__wurst_destroy"));
}

private List<String> genericTupleDispatchCase(Random random, int caseIndex) {
private List<String> genericTupleDispatchCase(Random random,
EnumSet<GenericDispatchShape> covered) {
List<String> source = new ArrayList<>();
Collections.addAll(source,
"package Test",
Expand Down Expand Up @@ -1636,46 +1652,59 @@ private List<String> genericTupleDispatchCase(Random random, int caseIndex) {
" int successes = 0");

int expected = 0;
List<GenericDispatchShape> shapes = new ArrayList<>(
EnumSet.allOf(GenericDispatchShape.class));
Collections.shuffle(shapes, random);
for (int i = 0; i < 16; i++) {
int value = random.nextInt(100) + 1;
switch (random.nextInt(7)) {
case 0 -> {
GenericDispatchShape shape = i < shapes.size()
? shapes.get(i)
: shapes.get(random.nextInt(shapes.size()));
covered.add(shape);
switch (shape) {
case TUPLE_INT -> {
source.add(" let value" + i + " = new Box<PairInt>(PairInt(" + value + ", " + (value + 1) + "))");
source.add(" if value" + i + ".matches(x -> x.a == " + value + ")");
source.add(" successes++");
source.add(" destroy value" + i);
}
case 1 -> {
case TUPLE_TEXT -> {
source.add(" let value" + i + " = new Box<PairText>(PairText(\"v" + value + "\", " + value + "))");
source.add(" if value" + i + ".matches(x -> x.a == \"v" + value + "\")");
source.add(" successes++");
source.add(" destroy value" + i);
}
case 2 -> {
case NESTED_TUPLE_INT -> {
source.add(" let value" + i + " = new Nested<PairInt>(PairInt(" + value + ", " + (value + 2) + "))");
source.add(" if value" + i + ".matches(x -> x.b == " + (value + 2) + ")");
source.add(" successes++");
source.add(" destroy value" + i);
}
case 3 -> {
case NESTED_TUPLE_TEXT -> {
source.add(" let value" + i + " = new Nested<PairText>(PairText(\"v" + value + "\", " + value + "))");
source.add(" if value" + i + ".matches(x -> x.a == \"v" + value + "\")");
source.add(" successes++");
source.add(" destroy value" + i);
}
case CLASS_PREDICATE -> {
source.add(" let value" + i + " = new Box<Foo>(new Foo())");
source.add(" if value" + i + ".matches(x -> x != null)");
source.add(" successes++");
source.add(" destroy value" + i);
}
case 4 -> {
case OTHER_CLASS_PREDICATE -> {
source.add(" let value" + i + " = new OtherBox<Foo>(new Foo())");
source.add(" if value" + i + ".matches(x -> x != null)");
source.add(" successes++");
source.add(" destroy value" + i);
}
case 5 -> {
case OTHER_CLASS_PREDICATE_SECOND_TYPE -> {
source.add(" let value" + i + " = new OtherBox<Bar>(new Bar())");
source.add(" if value" + i + ".matches(x -> x != null)");
source.add(" successes++");
source.add(" destroy value" + i);
}
default -> {
case CLASS_IMPLEMENTATION -> {
source.add(" let value" + i + " = new Box<Foo>(new Foo())");
source.add(" if value" + i + ".matches(new FooPredicate())");
source.add(" successes++");
Expand Down
Loading