Update wc3libs for Reforged 3 W3I - #1309
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 303694b680
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| implementation 'org.xerial:sqlite-jdbc:3.46.1.3' | ||
| implementation 'com.github.inwc3:JMPQ3:v2.0.1' | ||
| implementation 'com.github.inwc3:wc3libs:5ad2e5be4c480bb14112222521e6bc5571d00076' | ||
| implementation 'com.github.inwc3:wc3libs:52924b921f' |
There was a problem hiding this comment.
This dependency bump introduces support for a new W3I format without adding a Reforged 3 W3I fixture or a test that parses, modifies, and writes it. The existing cited suites cover patch selection, map headers, and import manifests rather than the new format, so an incompatible or lossy implementation—particularly through the Lua path that forces W3I version 0x1F—could ship undetected. Repository policy requires tests demonstrating new behavior.
AGENTS.md reference: AGENTS.md:L62-L64
Useful? React with 👍 / 👎.
1 participant
Bumps wc3libs to 52924b921f to support the Warcraft III Reforged 3.0 W3I format. Validation: WurstBuildConfigTests, MapRequestPatchTargetTests, ImportFileTests, and make_for_userdir passed.