Support Warcraft III 3.0 core JASS - #82
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2f2348c28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| private val BUNDLED_CORE_JASS_PATCH_FOLDERS = mapOf( | ||
| DEFAULT_PATCH to "v2.0", | ||
| DEFAULT_PATCH to "v3.0", |
There was a problem hiding this comment.
When a project remains pinned to wc3Patch: v2.0 and jass-history is unavailable, changing the only v2.0 map key indirectly via DEFAULT_PATCH removes its fallback: hasBundledCoreJass("v2.0") now returns false and materializeFile throws, even though core-jass/v2.0/common.j and blizzard.j are still bundled. Keep an explicit "v2.0" to "v2.0" entry alongside the new v3.0 default.
AGENTS.md reference: AGENTS.md:L29-L29
Useful? React with 👍 / 👎.
1 participant
No description provided.