Add WC3 patch alignment workflow - #83
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07218d74c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
💡 Codex ReviewWurstSetup/src/main/kotlin/file/SetupApp.kt Line 276 in 3c05abf  Avoid repairing config during read-only patch checks
When AGENTS.md reference: AGENTS.md:L51-L52 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the round-two read-only loader finding in 0f98099: patch commands now load recovery defaults without persisting them; a successful explicit align may still repair the config. Added regression coverage and reran the full suite. |
|
@codex review |
💡 Codex ReviewWurstSetup/src/main/kotlin/file/Wc3ClientDetector.kt Lines 154 to 155 in 0f98099  Match the build-info row to the selected client channel
When Retail and PTR coexist and AGENTS.md reference: AGENTS.md:L51-L52 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Addressed the round-three Retail/PTR channel finding in 81cb480: detector row selection now carries the chosen executable channel into .build.info (w3 for retail, w3t for ptr). Added coexistence regressions and reran the full suite. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81cb480123
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afdeca99bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3574699a71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b99df227b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| configData = WurstProjectConfig.loadProject( | ||
| configFile, | ||
| persistRecovery = setup.command != CLICommand.PATCH | ||
| )!! |
There was a problem hiding this comment.
When wurst.build is malformed, loadProject(..., false) still returns a synthesized default configuration; because this mode also applies to patch align, a supported client then causes handleUpdate to replace the active configuration with that fallback, discarding dependencies, build metadata, and any custom stdlib fork. The backup makes recovery possible but does not prevent the destructive migration, so alignment should distinguish a parse failure and abort rather than treating the fallback as the project configuration.
AGENTS.md reference: AGENTS.md:L51-L51
Useful? React with 👍 / 👎.
1 participant
Summary
grill patchstatus and explicitgrill patch alignmigration commands.build.inforowwc3Patch, the official stdlib branch, and Grill-owned core JASS together while preserving custom stdlib forkswurstStdlib2:v2.0branch beforegrill installupdates dependenciesAcceptance criteria
wurst.buildand updates all patch-coupled project inputsVerification
./gradlew.bat test— 88/88 tests passed./gradlew.bat compileKotlin— passed./gradlew.bat make_for_userdir— passedgrill patchsmoke test against WC33.0.0.24268— correctly reported an aligned v3 projectgit diff --check— cleanKnown gaps
.build.info; older installations without exact metadata remain unchanged and can be selected explicitly during project generation