Skip to content

Add Warcraft III v3 native wrappers - #479

Merged
Frotty merged 1 commit into
masterfrom
codex/wc3-v3-native-wrappers
Sep 13, 2026
Merged

Frotty merged 1 commit into
masterfrom
codex/wc3-v3-native-wrappers

Conversation

@Frotty

@Frotty Frotty commented Sep 13, 2026

Copy link
Copy Markdown
Member

Summary

  • move WurstStdlib2's declared WC3 target from v2.0 to v3.0
  • add idiomatic extensions and focused packages for every native declaration introduced by WC3 v3
  • cover inventory/loadouts, units, camera, destructables, effects, frames, input, triggers, doodads, terrain fog, HD water, cinematics, and new native handle conversions
  • preserve Z in the existing vec3 destructable factory now that the v3 API is the main line
  • expose the new doodad API through the standard Wurst import surface

Acceptance criteria

  • every native added between the v2 and v3 common.j snapshots has a typed stdlib entry point
  • local input-state wrappers explicitly warn against driving synchronized state
  • public APIs use semantic Wurst types such as vec2, vec3, and angle
  • existing stdlib tests remain green

Verification

  • native coverage audit — 137/137 added declarations referenced
  • grill typecheck --quiet — passed
  • grill test --quiet — 504/504 tests passed
  • git diff --check — clean

Compatibility

  • the pre-v3 master state is preserved on the published v2.0 branch for Grill to select for older project targets

Known gaps

  • new engine-native behavior is compile-verified; it has not been exercised in a dedicated Warcraft III runtime map

@Frotty

Frotty commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T09:08:01.516800Z 4998a0d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4998a0da46

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread wurst/_handles/Destructable.wurst
@Frotty
Frotty merged commit 55effdb into master Sep 13, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant