ci: run the test job on pull_request, not just push-to-main - #37
Merged
Conversation
Release workflow only triggered on push, so PRs merged with no CI signal at all (mergeStateStatus read CLEAN, which just meant no required check existed). Adds a pull_request trigger alongside the existing push trigger so the same test job gates PRs too. The release job's existing 'if: github.ref == refs/heads/main' guard already prevents it from running on pull_request events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced during the 2026-08-06 boss-authorized batch-merge (task_1786020006187): this repo's Release workflow only triggers on
pushto main, so PRs merge with zero CI signal —gh run list --branch <PR-branch>returns nothing, andmergeStateStatus: CLEANjust means no required check exists, not that anything passed.Adds a
pull_requesttrigger alongside the existingpushtrigger. The existingtestjob (lint/build/test, Node 20+22 matrix) now gates PRs too. Thereleasejob'sif: github.ref == 'refs/heads/main'guard already prevents it from running onpull_requestevents, so this only adds test coverage — no change to the release path.Mirrors the pattern sibling repos already use (e.g. node-connectwise-automate, node-syncro).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.