Skip to content

fix: 修复了 resizewindow 部分情况下不触发窗口重绘的 BUG - #395

Closed
FeJS8888 wants to merge 1 commit into
x-ege:masterfrom
FeJS8888:fix-resizewindow
Closed

fix: 修复了 resizewindow 部分情况下不触发窗口重绘的 BUG#395
FeJS8888 wants to merge 1 commit into
x-ege:masterfrom
FeJS8888:fix-resizewindow

Conversation

@FeJS8888

@FeJS8888 FeJS8888 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • 修复窗口调整大小后更新标记未正确重置的问题,提升窗口重绘和刷新行为的稳定性。

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 6e720c87-be36-4784-81da-3975b807db57

📥 Commits

Reviewing files that changed from the base of the PR and between 8e3de3e and ee6eed3.

📒 Files selected for processing (1)
  • src/window.cpp

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

窗口调整完成后,resizewindow 现在会在 Windows 和非 Windows 路径中将 pg->update_mark_count 重置为 0。

Changes

窗口调整状态

Layer / File(s) Summary
重置调整后的更新标记计数
src/window.cpp
resizewindow 在调整完成后,将 pg->update_mark_count 设置为 0。Windows 和非 Windows 路径均应用此更新。

Estimated code review effort: 1 (简单) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ee6ee

This localized fix resets the window update marker after resizing on both supported paths so the window can be redrawn correctly. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: wysaid

Poem

小兔检查窗口边框,
调整完成计数清零。
Windows 路径同步完成,
非 Windows 路径也不例外。
更新标记轻轻归零,
窗口焕然一新。

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题明确说明了 resizewindow 在部分情况下未触发窗口重绘的修复,与本次重置 update_mark_count 的改动一致。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FeJS8888
FeJS8888 requested a review from Ltabsyy September 2, 2026 13:44
@Ltabsyy Ltabsyy closed this Sep 2, 2026
@Ltabsyy

Ltabsyy commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

抢我PR?瞬关

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants