Conversation
os.Stat can fail with EACCES (service-user installs); IsNotExist is false then and the nil FileInfo dereference panics addStorage. Validate via resolveVolumePath and reject any stat failure as a bad path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a local storage folder panics the server when os.Stat fails with anything but not-exist (e.g. EACCES on a service-user install):
IsNotExist is false, so !fi.IsDir() dereferences the nil FileInfo. Every click panics (recovered per-connection by net/http, folder never added):
This factors the check into resolveVolumePath, which treats any stat failure as a bad path, and the endpoint keeps its existing 400 response. Adds TestResolveVolumePath (missing path, file, and permission-denied cases).
Note: I could not run the app test suite locally on a pristine checkout (go test hits the flag.Parse issue from #2252); the identical code passes here via CI-worthy paths and was verified green on my fork.