Conversation
POST /filenames/{scene-id} with {"filenames": [...]} merges basenames
into Scene.FilenamesArr with exact-match dedupe, json.Marshal encoding
identical to the scan matcher write path, AddAction audit on change, and
search-index refresh. Missing key 400s, bad ids 404, corrupt stored JSON
500s without write; a package mutex serializes concurrent appends.
Assisted-By: muse-spark-1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds POST /api/scene/filenames/{scene-id}, which merges basenames into the scene's filenames array without touching any other field.
Motivation: the only write path today is POST /api/scene/edit/{scene-id}, which overwrites every field it receives. External tools (e.g. download managers that know the expected filename for a scene ahead of the next library scan) have no way to register a filename non-destructively — they must GET the full scene, merge, and POST it all back.
Behavior:
Includes pkg/api/scenes_filenames_test.go covering append, idempotency, and the error cases. No changes to scan, edit, or scrapers.