Conversation
Ports SorenSkovSkov's xbapps#618 to current conventions: colly v2, ScrapeWG 7-arg signature, 5-arg registration with domain. Scenes are built from the channel listing thumbnails since Pornhub requires login for scene details; single-scene URLs visit best-effort. Supersedes: xbapps#618 Assisted-By: muse-spark-1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #618, which is unmergeable as written (colly v1 import, 4-arg
registerScraper) and whose author (@SorenSkovSkov) has been inactive since 2022.This ports that PR's scraper to the current conventions: colly v2,
ScrapeWG7-arg signature, 5-arg registration with domain. Behavior is unchanged from the original: scenes are built from the channel listing thumbnails since Pornhub requires login for scene details; a single-scene URL is visited best-effort.Verified:
go build ./pkg/scrape/clean, and the hermetic registry tests pass with the new scraper registered (TestScraperIDsAreUnique,TestScraperFieldsArePopulated,TestScraperDomainsReduceToCoreDomain).Original PR: #618