Conversation
Ports agentfisk's xbapps#622 onto current master: per-file median speed is calculated from funscript actions, stored on files and scenes, shown in DeoVR titles (optional, behind funscript_speeds) and SceneCards, with min/max filters and asc/desc sort. Migrations are numbered 0088/0089 (the PR's 0028/0029 slots are long taken). Speed-in-title stays opt-in because it costs DeoVR's local-script matching. Supersedes: xbapps#622 Assisted-By: muse-spark-1.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #622, which has sat unmerged since 2021 (9 conflicting files against current master) and whose author (@agentfisk) has been inactive since 2023.
This ports that PR's feature onto current master, touching the same 17 files: the median per-action speed is calculated from funscript actions, stored on files and scenes, shown in DeoVR titles and SceneCards, with min/max filters and asc/desc sort. Two adaptations were needed:
0088/0089(the PR's0028/0029slots are long taken).funscript_speedsDeoVR option (default off), since it costs DeoVR's local-script matching; heatmap thumbnails stay behindrender_heatmaps.Also adds
pkg/tasks/funscripts_test.go, focused coverage for the speed calculation (median math over a fixture .funscript, plus a missing-file error case).Verified: touched Go packages build (
pkg/tasks,pkg/migrations,pkg/apitype-check; theui/distembed failure also occurs on pristine master without a built frontend), new tests pass, existingpkg/apitests and scrape registry tests pass. The two pre-existinggo vetcomplaints in untouched lines remain.Original PR: #622