Skip to content

docs(agents): fail fast on EROFS - #9

Merged
xdanger merged 1 commit into
mainfrom
docs/trash-ero-fail-fast
Aug 21, 2026
Merged

docs(agents): fail fast on EROFS#9
xdanger merged 1 commit into
mainfrom
docs/trash-ero-fail-fast

Conversation

@xdanger

@xdanger xdanger commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • require trash cleanup to fail immediately on EROFS
  • prevent sandboxed cleanup retries from consuming CPU indefinitely

Validation

  • git diff --check
  • mise exec github:huacnlee/autocorrect -- autocorrect --lint agents/AGENTS.md

Note

Low Risk
Documentation-only agent guideline; no runtime, security, or data-handling code changes.

Overview
Updates agent CLI guidance so trash cleanup fails immediately on EROFS and reports the error instead of retrying forever (which can spin CPU in a sandbox).

Reviewed by Cursor Bugbot for commit 96035a2. Bugbot is set up for automated code reviews on this repo. Configure here.

- 📝 prevent runaway cleanup retries when sandboxed Trash writes fail
@xdanger xdanger self-assigned this Aug 21, 2026
@xdanger
xdanger requested a lite review from Copilot August 21, 2026 06:36
@cursor

cursor Bot commented Aug 21, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_fe2e1141-1982-4140-bedb-409b2adec920)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Update the agent documentation so that any cleanup using trash fails immediately on EROFS and reports the error, rather than retrying indefinitely and potentially burning CPU in sandboxed environments.

This PR updates the agent development guidelines to clarify expected behavior when trash encounters a read-only filesystem (EROFS) during cleanup.

Changes:

  • Document “fail fast on EROFS” behavior for trash-based cleanup operations.
  • Explicitly forbid indefinite retry loops in sandboxed cleanup scenarios.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

Adds explicit guidance requiring agents to stop cleanup immediately when trash encounters a read-only filesystem error, preventing unbounded retries and CPU consumption.

  • Requires immediate failure and error reporting on EROFS.
  • Explicitly prohibits indefinite cleanup retries.

Confidence Score: 5/5

The PR appears safe to merge.

The updated agent guidance narrowly strengthens cleanup failure handling, and no actionable correctness, security, or quality issue remains.

Important Files Changed

Filename Overview
agents/AGENTS.md The documentation-only change clearly establishes fail-fast behavior for read-only filesystem errors without introducing a concrete defect.

Reviews (1): Last reviewed commit: "📝 docs(agents): fail fast on `EROFS`" | Re-trigger Greptile

@xdanger
xdanger merged commit 8967e7c into main Aug 21, 2026
3 checks passed
@xdanger
xdanger deleted the docs/trash-ero-fail-fast branch August 21, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants