Fix M-r history search losing newest-first order - #44
Open
mrcnski wants to merge 1 commit into
Open
Conversation
Hand completing-read a completion table whose display-sort-function and cycle-sort-function metadata preserve the input ring's newest-first order, instead of a bare list that completion frontends re-sort (vertico: by length then alphabetically; default completion: alphabetically). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: see PR title. Found in agent-shell.
Details
shell-maker-search-historybuilds its candidates from(ring-elements comint-input-ring), which is already ordered newest first, but hands them tocompleting-readas a bare list. Withoutdisplay-sort-functionmetadata, thecompletion frontend applies its own order: vertico re-sorts by length and then
alphabetically, default completion sorts the
*Completions*bufferalphabetically. Recent prompts end up buried.
Repro
In any shell-maker shell with vertico at default settings, submit
bbb, thena, thencc, and hitM-r— candidates show asa,cc,bbbinstead ofcc,a,bbb.Fix
Wrap the candidates in a completion table that declares
display-sort-functionand
cycle-sort-functionasidentity, so every frontend keeps the ring orderand
M-rmatches comint's own newest-first history commands. A plain closurerather than a newer metadata helper, to stay within the
emacs "27.1"floor.(
delete-dupskeeping the first — i.e. most recent — occurrence of a repeatedprompt is intentional and unchanged.)
🤖 Generated with Claude Code