Add ocean ruin loot support for 1.13+ - #17
Open
AdverseMiller wants to merge 11 commits into
Open
Conversation
xpple
requested changes
Jun 1, 2026
xpple
left a comment
xpple
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR, and for addressing the comments I made on Discord.
The structure of the code is a bit different from other piece generation code, where piece and loot generation are separate. The same applies to the use of OceanRuinLootRng to keep track of the random calls per chunk. What is your reasoning?
Also, can the rotPos function from features/stronghold.c be used instead of getOceanRuinChestPos? If so, you could put it in a general piece.h file, as I do in #11 currently.
xpple
requested changes
Jun 2, 2026
xpple
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.