Give the GUI its own version, and set it to 3.50-beta-1 - #83
Merged
Conversation
WinHTTrack.exe and the installer now take their version from the new WinHTTrack/version.h. httrack.exe and libhttrack.dll keep reporting whatever the engine stamped them with, and CI holds each pair to the tree that built it. The beta ships over a 3.49 engine, so the old rule of one version across all four would have forced the release to be called 3.49-15. The numeric form is 3.49.99.1, not 3.50.0.1, so the eventual 3.50 release outranks its own betas. Nothing here tracks the engine version any more, so an engine bump can no longer turn master red. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WinHTTrack.exe and the installer now take their version from a new
WinHTTrack/version.h, set to 3.50-beta-1.httrack.exeandlibhttrack.dllstill report what the engine stamped them with, currently 3.49-15, and CI holds each pair to the tree that built it instead of demanding one version across all four. The beta ships over a 3.49 engine, so the old rule would have forced the release to be called 3.49-15.The numeric form is 3.49.99.1 rather than 3.50.0.1, so the eventual 3.50 release outranks its own betas. The installer becomes
httrack_x64_3.50-beta-1.exe, the About box reads "WinHTTrack Website Copier 3.50-beta-1, engine 3.49-15", and--versionprints both. Nothing in this repo tracks the engine version any more, so an engine bump can no longer turn master red here.