Conversation
Transient P2P and backup control messages retained attacker-supplied protobuf unknown fields after parsing, increasing their in-memory footprint without affecting message semantics. Parse non-persistent control messages with DiscardUnknownFieldsParser while preserving the exact serialized bytes of persisted and consensus-critical messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transient P2P and backup control messages retained attacker-supplied protobuf unknown fields after parsing, increasing their in-memory footprint without affecting message semantics.
Parse non-persistent control messages with DiscardUnknownFieldsParser while preserving the exact serialized bytes of persisted and consensus-critical messages.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details