Phase 2: dependency hygiene + Node-12 install fixes + dev-mount harness paths - #150
Closed
xywang68 wants to merge 4 commits into
Closed
Phase 2: dependency hygiene + Node-12 install fixes + dev-mount harness paths#150xywang68 wants to merge 4 commits into
xywang68 wants to merge 4 commits into
Conversation
Drop unused direct deps (@hapi/hapi, hoek, cryptiles, deep-extend, json-diff, minimist-options, moment, url-parse, words-to-numbers, inquirer), Node-core shim deps (assert, child_process, path), and unused devDeps (@rpii/wdio-html-reporter, @wdio/allure-reporter, @wdio/dot-reporter, @wdio/jasmine-framework, allure-commandline, chromedriver, wdio-chromedriver-service, devtools). Normalize unbounded >= version ranges to caret. Delete orphaned old-findTargetImage.js. Keep wdio7/@wdio/sync + reporter stack intact (removed in later phases).
…onorepo Without a committed lockfile, npm6 (container Node 12) resolved @wdio/cli's inquirer ^8 to 8.2.7, whose @inquirer/external-editor@1.x requires Node >=18 (\?\? syntax) and crashed 'npx wdio' at startup with 'Unexpected token ?'. Pin inquirer 8.2.6 as a direct dep (uses Node-12-safe external-editor@^3) and drop the npm8-only overrides block (ignored by the container's npm6). Also fix two post-consolidation leftovers that broke running the gate from the monorepo root: docker-compose AUTOBDD_SRC default ../AutoBDD (sibling layout) now points to ../.. (repo root), and dev/bootstrap-dev.sh resolves AutoBDD root three levels up instead of the old sibling ../../AutoBDD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 — dependency hygiene on the current runtime (wdio 7 / Node 12)
Per the consolidated upgrade plan (
docs/upgrade-plan.md, Phases 1–8), Phase 2 removes dead/unused dependencies and normalizes version pins without changing the wdio/Node major.Changes
@hapi/hapi,hoek,cryptiles,deep-extend,json-diff,minimist-options,moment,url-parse,words-to-numbers,inquirer(as direct dep);assert,child_process,path(Node-core shims);@rpii/wdio-html-reporter,@wdio/allure-reporter,@wdio/dot-reporter,@wdio/jasmine-framework,allure-commandline,chromedriver,wdio-chromedriver-service,devtools.>=ranges → caret for retained deps.framework/scripts/old-findTargetImage.js(unreferenced 2021 duplicate). Keptabdd_local.js(liveLOCALSELPORTconfig branch).inquirer@8.2.6as a direct dep. Without a committed lockfile, the container's npm6 resolved@wdio/cli'sinquirer ^8to 8.2.7, whose Node-18@inquirer/external-editor(??syntax) crashednpx wdioat startup (Unexpected token '?'). 8.2.6 uses Node-12-safeexternal-editor@^3. Dropped the npm8-onlyoverridesblock.test-projects/autobdd-test/docker-compose.ymlAUTOBDD_SRCdefault../AutoBDD(sibling layout) →../..(repo root);dev/bootstrap-dev.shresolves AutoBDD root three levels up..gitignorethe vendoredxysikulixapinode-gypbuild/output.Gate (dev-mount, Node 12, image
xyteam/autobdd:3.0.0)npm installclean on the trimmed set.make e2e-test(withclean): single-runner + parallel-runner (15 scenarios) + auto-runner (5 features) all green; all 3 HTML reports generated.Notes
cleanprecedes it intest-all/make autobdd-test); stale.run/db.subjsonfrom an aborted prior run make it reportExpected total: 0.Closes Phase 2 of the plan. Next: Phase 3 (sync→async, still on the 3.0.0 image).