[codex] Add GitHub source link to site footer - #6
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gp300 | 073076e | Commit Preview URL Branch Preview URL |
Apr 12 2026, 07:09 PM |
There was a problem hiding this comment.
Pull request overview
Adds a GitHub “Source Code” link to the web dashboard footer now that the repository is public, and introduces a regression test to enforce link presence and ordering.
Changes:
- Inserted “Source Code at GitHub” link in
public/index.htmlfooter between the CLI and Polymarket attribution. - Added
test_footer.pyto verify footer ordering and presence of the GitHub repo URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
public/index.html |
Adds a GitHub source link to the footer, positioned after the CLI link. |
test_footer.py |
Adds a regression test asserting footer ordering and that the GitHub URL appears in the HTML. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cli_label = "CLI:" | ||
| github_label = "Source Code at " | ||
| github_link = 'href="https://github.com/y3zai/gp300/"' | ||
| polymarket_label = "Data from " |
There was a problem hiding this comment.
The test hard-codes the GitHub URL with a trailing slash. Elsewhere (e.g., README) the canonical repo URL is written without the trailing slash, and both forms are valid; this makes the test more brittle than necessary. Consider normalizing the URL (no trailing slash) in both the HTML and test, or relaxing the assertion to accept either form (or parse the href value and compare after stripping a trailing '/').
| CLI: <a href="https://pypi.org/project/gp300/" target="_blank" rel="noopener"><code>pip install gp300</code></a> · | ||
| Source Code at <a href="https://github.com/y3zai/gp300/" target="_blank" rel="noopener">GitHub</a> · | ||
| Data from <a href="https://polymarket.com" target="_blank" rel="noopener">Polymarket</a> · Updated every 5 min |
There was a problem hiding this comment.
This adds the GitHub repo link with a trailing slash in the href. The README and most references typically use the canonical form without a trailing slash; picking one canonical URL (and matching the regression test) will avoid unnecessary future churn.
|
@copilot review |
The previous review feedback about the trailing slash has already been addressed in commit |
What changed
Source Code at GitHublink to the site footerpublic/index.htmlWhy
The repository is now public, so the site footer should provide a direct path to the source code.
Validation
/Users/yu_zheng/workspace/gp300/.venv/bin/pytest -q test_footer.py/Users/yu_zheng/workspace/gp300/.venv/bin/pytest -q