deploy: pull MinIO and mc from the pinned GHCR mirror; quay.io withdrew them - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly scheduled run 36089618923 failed in functional: 901 passed and 3 errors, on the same
maincommit as the green PR #2 and main runs. The three errors are the MinIO fixture failing to pullquay.io/minio/minio:latest("unauthorized").MinIO has withdrawn its public images from quay.io.
latest, our pinnedRELEASE.2024-12-18T13-15-44Zandmcall return "no such manifest", so every run from now on would break. That covers the functional fixture, the e2e kind pre-pull, the chart and compose.Fix: the exact pinned images, byte-identical (no rebuild), are mirrored to public GHCR packages:
ghcr.io/yabinma/mirror/minio:RELEASE.2024-12-18T13-15-44Zghcr.io/yabinma/mirror/mc:RELEASE.2025-08-13T08-35-41ZEverything now points at them:
deploy/versions.env(the single source; e2erun.shreads it);minio.imageandminio.mcImage;versions.envpin instead oflatest.test_delivery_images.py's old "MinIO comes from quay.io" rule becomes "MinIO comes from the GHCR mirror at a pinnedRELEASE.*tag, and chart, compose and fixture all equalversions.env". It has 23 mutants: quay.io,latest, Docker Hub, and a mismatch.The compose and swarm docs now say, as the Kubernetes docs already did, that bundled MinIO is dev/e2e only: a frozen, unpatched image. Production points
storage.s3.*at its own S3/MinIO.The light review approved it with no findings.
🤖 Generated with Claude Code