Skip to content

Deprecate TTableClient::StreamExecuteScanQuery in favor of query client #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vgvoleg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate TTableClient::StreamExecuteScanQuery in favor of query client #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Deprecated `TTableClient::StreamExecuteScanQuery`, use `NQuery::TQueryClient::StreamExecuteQuery` instead.

# v3.22.0

* Added `IWriteSession::Flush` to asynchronously wait until all previously accepted topic writes are acknowledged.
Expand Down
2 changes: 2 additions & 0 deletions include/ydb-cpp-sdk/client/table/table.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,9 +1768,11 @@ class TTableClient {
TAsyncReadRowsResult ReadRows(const std::string& table, TValue&& keys, const std::vector<std::string>& columns = {},
const TReadRowsSettings& settings = TReadRowsSettings());

[[deprecated("Use NQuery::TQueryClient::StreamExecuteQuery instead")]]
TAsyncScanQueryPartIterator StreamExecuteScanQuery(const std::string& query,
const TStreamExecScanQuerySettings& settings = TStreamExecScanQuerySettings());

[[deprecated("Use NQuery::TQueryClient::StreamExecuteQuery instead")]]
TAsyncScanQueryPartIterator StreamExecuteScanQuery(const std::string& query, const TParams& params,
const TStreamExecScanQuerySettings& settings = TStreamExecScanQuerySettings());

Expand Down
3 changes: 3 additions & 0 deletions tests/integration/basic_example/basic_example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,10 @@ static NYdb::TStatus ScanQuerySelect(TTableClient client, const std::string& pat
.Build();

// Executes scan query
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
auto resultScanQuery = client.StreamExecuteScanQuery(query, parameters).GetValueSync();
#pragma GCC diagnostic pop

if (!resultScanQuery.IsSuccess()) {
return resultScanQuery;
Expand Down
Loading