Add Topic Reader delivered metric - #715
Open
KirillKurdyukov wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (71.05%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
============================================
- Coverage 73.11% 73.07% -0.05%
- Complexity 3566 3572 +6
============================================
Files 391 392 +1
Lines 16497 16531 +34
Branches 1730 1733 +3
============================================
+ Hits 12062 12080 +18
- Misses 3817 3825 +8
- Partials 618 626 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KirillKurdyukov
marked this pull request as draft
September 3, 2026 10:41
KirillKurdyukov
marked this pull request as ready for review
September 3, 2026 12:17
KirillKurdyukov
force-pushed
the
codex/topic-reader-metrics
branch
3 times, most recently
from
September 4, 2026 13:55
6dad16c to
46d701a
Compare
KirillKurdyukov
force-pushed
the
codex/topic-reader-metrics
branch
4 times, most recently
from
September 7, 2026 07:16
25987b2 to
3deb1e4
Compare
KirillKurdyukov
force-pushed
the
codex/topic-reader-metrics
branch
from
September 7, 2026 07:33
3deb1e4 to
80fdba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tech.ydb.core.metrics.Meterabstraction; the default remainsMeter.NOOPand metric usage is reported throughObservability.ydb.topic.reader.delivered.messagescounter with unit{message}and attributestopicandconsumer.reader.namewith the exact configured non-emptyReaderName. It is omitted for null/empty names; no fallback identifier is generated, so unnamed readers intentionally aggregate by the other attributes.Tests
./mvnw -pl core,topic -am clean test -DskipITs./mvnw -pl topic -am -DskipITs -Dtest=ReaderMetricsTest -Dsurefire.failIfNoSpecifiedTests=false test