Desktop workbench overhaul: toolbar options, input/constants/result redesign, design-token pass - #84
Open
yilibinbin wants to merge 139 commits into
Open
Desktop workbench overhaul: toolbar options, input/constants/result redesign, design-token pass#84yilibinbin wants to merge 139 commits into
yilibinbin wants to merge 139 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop GUI overhaul for DataLab's workbench: toolbar-driven options, a redesigned
input/constants/result layout, on-demand LaTeX, a full design-review token pass, plus a
batch of UX polish and bug fixes accumulated on this branch. One Python core, two frontends
— desktop changes only; the web app and compute layers are untouched.
Highlights
Layout / workbench
输入数据 / 常数sheet tabs; each tab self-contained.[输入数据] + [one config card]per mode; mode selector on the toolbar.Input / constants UX
使用数据文件checkbox — a non-empty file path now takes precedence over themanual editor (which greys/hides live when a path is entered). Same for constants.
输入常数title, anN 行row-count, and a?help button (matching thedata card); both input cards now carry a consistent border + padding.
LaTeX / result
生成 TeX/预览 PDF(no generate-checkbox); tex-rebuild inputs persist in theworkspace so it works after reopen without recomputing.
不确定度位数moved to the result panel with live re-render.push OK off-screen; result font-size control live-updates.
Feature removal
单位标注(units) feature end-to-end on the UI side (not general enough); thedisplay-only backend is left as harmless dead code and old workspaces still open.
Design-review token pass (
theme.py)(
text_primary/text_muted/border/card_bg/region_bg/surface_raised/surface_hover).RADIUS_CARD=8/RADIUS_CONTROL=6); one canonicalCARD_PADDING; formula-preview border fixed; fixed-white tutorial card text pinned dark.Precision / workspace correctness
Review gates already passed on this branch
all confirmed findings fixed (mpf precision, theme-toggle stale styles, animation-fight,
tutorial contrast, file-precedence live feedback, …). Gemini's
agychannel timed out on thelast two rounds — its lens was covered by direct code inspection and noted as such.
convergence finished, per-keystroke constants refresh gated, dead widget removed.
Test plan
QT_QPA_PLATFORM=offscreen pytest -q— full suite green (a couple of files run separately dueto an offscreen Qt-teardown hang unrelated to these changes).
constants editor, formula preview, workspace controller, option reachability) all pass.
pixmap inset, constants row-count + control-row placement, theme-toggle restyle, mpf round-trip.
Requesting
CodeRabbit review before merge to
main.Summary by CodeRabbit