fix: restore assert method with implicit inference - #13
Merged
Conversation
Restore implicit typescript inference like
`assert(ivView && ivView.xVariable && ivView.yVariable);` which assert
`ivView`, `ivView.xVariable` and `ivView.yVariable` are not falsy.
Or `assert(color.kind === 'fixed', 'Only fixed colors are supported');`
with `kind` for type discriminated union assert `color` is `{kind: 'color', color: string}`
Refs: zakodium-oss/react-science#1028 (comment)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 25 25
Branches 6 6
=========================================
Hits 25 25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
targos
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore implicit typescript inference like
assert(ivView && ivView.xVariable && ivView.yVariable);which assertivView,ivView.xVariableandivView.yVariableare not falsy.Or
assert(color.kind === 'fixed', 'Only fixed colors are supported');withkindfor type discriminated union assertcoloris{kind: 'color', color: string}Refs: zakodium-oss/react-science#1028 (comment)
Refs: f107355#diff-36600636ec4d5ea8a05c7eabcca9531918c5e02d66d92180ad367c8e67e79a6a