Misc API bug fixes, update examples, documentation and build scripts - #293
Open
joseph-henry wants to merge 1 commit into
Open
Misc API bug fixes, update examples, documentation and build scripts#293joseph-henry wants to merge 1 commit into
joseph-henry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP -- Still validating, more to come
This gets the repo building again from a clean clone and clears out a batch of API bugs along the way. The main change is updating the bundled ZeroTierOne core from
1.12to1.16.2, which is what was breaking./build.sh hostfor anyone on a recent compiler. The old pin shipped a copy ofprometheus-cpp-litethat usedstd::invalid_argumentwithout including<stdexcept>(fixes #284, fixes #269).The API delta between those two versions of ZTO turned out to be small, mostly a new node config parameter and the
C25519toECCrename.Several paths in
Central.cpp,NodeService.cpp, andVirtualTap.cppcopied caller- or peer-controlled lengths into fixed-size buffers with no bounds check, including an Ethernet frame length that could underflow to roughly 4GB (supersedes #287).The C# bindings were truncating node IDs that begin with a zero and ignoring the
sizeargument toSocket.Send/Receivewhile handing an unpinned array to native code (fixes #274, fixes #257, supersedes #275 and #276).The remainder is mostly cleanup:
build.shnow fails properly instead of exiting 0 when the build fails, the C examples had a few bugs fixed: An uninitialized fd, two misplaced parens that swallowed error codes, an unboundedmemcpy. Also improved documentation a bit with--helpoutput instead of a sibling README.Fixes #284
Fixes #269
Addresses concern in #121
Fixes #274
Fixes #257
Supersedes #287, #275, #276