Add Prettier for code formatting - #129
Merged
Merged
Conversation
One-time reformat prior to wiring up Prettier tooling, kept isolated from the tooling change so this diff is pure formatting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds Prettier (defaults only, no .prettierrc) scoped to src/**/*.{ts,tsx}
via .prettierignore, with format/format:check npm scripts. Wires up
husky + pretty-quick to auto-format staged files on commit, matching
manager-ui's pattern. The husky prepare script is guarded with
`|| true` so npm ci --omit=dev doesn't fail when husky isn't installed.
Resolves #127
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Review — ✅ No blockers |
agalin920
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #127
Summary
.prettierrcis included. This is intentional: the issue calls for matching manager-ui's zero-decision setup, so there's no repo-specific config to diverge from.format/format:checknpm scripts and a.prettierignorescoped tosrc/**/*.{ts,tsx}.pretty-quick --stagedpre-commit hook so new commits auto-format and can't drift out of style again. Thepreparescript ishusky || true(not plainhusky) — this is husky's own documented pattern so thatnpm ci --omit=dev(production/CI installs without devDependencies) doesn't fail with "husky: not found".src/vianpx prettier --write "src/**/*.{ts,tsx}"— no logic changes. This is deliberately its own commit (ecad319), separate from the tooling commit (99ccfd9) that adds Prettier itself, so the reformat diff doesn't get tangled up with the tooling/config changes during review (this was itself an acceptance criterion on the issue).CLAUDE.mdto document the new formatting tooling.Out of scope
format:checkis not wired into any CI workflow here. That's intentionally deferred to a separate issue covering the CI build/typecheck gate.Test plan
npm run format:checkexits clean on this branchnpx tsc --noEmitpasses clean (confirms the mechanical reformat introduced no type errors)npm ci --omit=devdoes not fail on thepreparescript (husky guard)Notes
Pure formatting + build-tooling change — no visual or runtime behavior change, so no screenshots are included.