Add CI static checks workflow - #132
Open
finnar-bin wants to merge 2 commits into
Open
Conversation
Runs npm ci, build (tsc), format:check, and lint on every PR into main as a non-required status check. Making it required is a follow-up for a repo admin via branch protection settings. Closes #125 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code Review — ✅ No blockers · 🟡 2 warning(s) — see inline comments |
- Drop the redundant npm ci: build step now runs npx tsc directly instead of npm run build (which itself runs npm ci && tsc). - Scope the job to permissions: contents: read (least privilege, matching the pattern in claude-auto-reviewer.yml). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Review — ✅ No blockers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/static-checks.yml, a non-required PR check onpull_request → mainthat runs (in order)npm ci,npm run build(tsc, strict),npm run format:check(Prettier), andnpm run lint(ESLint).actions/checkoutandactions/setup-nodeare pinned to commit SHAs, matching the pinning style used elsewhere in this repo (e.g.claude-auto-reviewer.yml); Node version is pinned to18.20.4to match thevolta.nodepin inpackage.json.Follow-up (not in this PR)
Making this check required needs a repo admin to enable it manually via the GitHub web UI: Settings → Branches → Branch protection rules on
main, adding "Static Checks / checks" to the required status checks list.Closes #125
Test plan
npm run format:checkandnpm run lintcurrently pass locally againstsrc/