Fix FTP upload file handle leak, correct deploy warning typo, and add rsync config test - #8
Open
zhang787jun wants to merge 1 commit into
Open
Fix FTP upload file handle leak, correct deploy warning typo, and add rsync config test#8zhang787jun wants to merge 1 commit into
zhang787jun wants to merge 1 commit into
Conversation
Review completed. No issues found. The changes correctly fix the file handle leak using a context manager, correct the typo in the deploy warning message, and add appropriate test coverage for the rsync config function. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
get_rsync_configsto increase confidence in deploy configuration selection.Description
deploy_ftpinfabfile.pyto open files with a context manager (with open(..., 'rb') as upload_file:) before callingftp.storbinaryso each file is closed after upload.fabfile.pyto usenot support {0} deploy methodinstead of the misspelled version.tests/test_fabfile.pywhich stubs optional dependencies (fabricandsimiki) to allow importingfabfile, and includes apytesttest that patchesfabfile.configsand assertsget_rsync_configs()returns thersyncentry.Testing
pytest -qin the repository root and the test suite passed:1 passed in 0.34s.deploy_ftplogic via static inspection and ensured the repository imports succeed in the test environment by stubbing optional modules.Codex Task