Changed StorageGroup.list_candidate_adapter_ports() to return None for FC-type - #2240
Open
andy-maier wants to merge 1 commit into
Open
Changed StorageGroup.list_candidate_adapter_ports() to return None for FC-type#2240andy-maier wants to merge 1 commit into
andy-maier wants to merge 1 commit into
Conversation
…r FC-type Details: * FC-type storage groups do not have a property 'candidate-adapter-port-uris'. The StorageGroup.list_candidate_adapter_ports() method raised KeyError when called for FC-type storage groups. However, this was not documented. Changed the method to return None when called for FC-type storage groups and documented that. This is an incompatible change for users that handle that KeyError exception. Such code needs to be changed to test for None instead. Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Collaborator
|
coverage: 77.273% (-0.005%) from 77.278% — andy/fix-fc-sg into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.