Skip to content

Update abcjs version for Tune display and add additional abcjs-based tools#89

Merged
zmoon merged 66 commits into
mainfrom
anywidget
Jan 17, 2026
Merged

Update abcjs version for Tune display and add additional abcjs-based tools#89
zmoon merged 66 commits into
mainfrom
anywidget

Conversation

@zmoon

@zmoon zmoon commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Now using anywidget for the display (_repr_html_)

More ways to use abcjs:

  • headless SVG creation via Node.js (pyabc2.sheet, not sure about the module name)
  • create/open HTML page
  • interactive toy editor widget in the notebook using ipywidgets
    • planning to keep this as an example (in the notebook) but create an editor widget in js, so that the interactivity fully works in the docs

todo:

  • document the widget attrs
  • cov

zmoon added 30 commits November 29, 2024 10:25
@zmoon
Windows flit note
32cd9fa
@zmoon
Add anywidget to dev extra
4484672
@zmoon
Initial AnyWidget setup
450069a
@zmoon
Initial rendered ABC display
935d00b 
- seems like abcjs is not ES6 so can't `import`
- loading from CDN happens on widget creation, but not update
- but currently creation controls where it shows up
  (the first #music, though update creates additional elements)
@zmoon
Update on change
e5d09d8
@zmoon
Some abcjs renderAbc option sliders
55626ed
@zmoon
Params can be set in init
ff10528 
without needing to override __init__
@zmoon
todo
e353932
@zmoon
Only load once and show logo then
b009f3c 
seems like restarting notebook kernel won't get you to the first
load, have to refresh the web page

and it would be nice to display it at the same hierarchy level
as the widget container, instead of within it

could also add an option to include it within the widget when
requested
@zmoon
Expose the SVGs
4e2d335 
tune.engraver.svgs also them, but not sure if the same thing or not
@zmoon
Expose more display options
a0e647d
@zmoon
Split logo URL more
f8c8ac3
@zmoon
fmt
c4c7d59
@zmoon
Add optional deps
afc6c65
@zmoon
Make SVG with node (will add args)
7c8b032
@zmoon
Receive SVG str in Python
a8964ab
@zmoon
Create function to render
b735d73
@zmoon
Pass the ABC via stdin
9905fbf
@zmoon
Python function
a325e43
@zmoon
Convert SVG to other formats with cairosvg
3598982
@zmoon
Tweak docstring
fdeb8e5
@zmoon
Update gitignore for test files
ae56fef
@zmoon
Document options
37df25e
@zmoon
Move compose with ipywidgets to module, update examples
92fd737
@zmoon
From fresh, first cell should show logo
b96befe
@zmoon
Use the widget for Tune _repr_html_
ada7c0e
@zmoon
Generate HTML page
f973a58
@zmoon
Add other widget deps, tweak abcjs mentions
ebf7d7f
@zmoon
Add docstring for sheet
0eb00bf
@zmoon
Merge remote-tracking branch 'origin/main' into anywidget
252a092
zmoon and others added 2 commits January 15, 2026 22:18
@zmoon
Apply suggestions from code review
2f39cfc 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0782cbf 
for more information, see https://pre-commit.ci
@zmoon zmoon changed the title Update abcjs version for Tune display and add additional tools Update abcjs version for Tune display and add additional abcjs-based tools Jan 16, 2026
zmoon added 15 commits January 16, 2026 21:30
@zmoon
Add warning for Tune HTML display deps
1a10aa7
@zmoon
When viewing HTML, keep session open, clean up tmp file on exit
10cc7f4
@zmoon
Move visual test of warning to test suite
ebb0664
@zmoon
Prevent ABC debug view from interpreting HTML
a5c58fd
@zmoon
Add widget attr helps
a9179a0 
these show up as description in the docs too
@zmoon
doc
53c34f7
@zmoon
Sort of test the html module
f0711e8
@zmoon
Don't cover npm build errors
03b7c1b
@zmoon
Test some svg_to errors
9d007eb
@zmoon
Test in_jupyter
a165f56
@zmoon
cov
d89f119
@zmoon
Try to debug why npm build running again in SVG example
870ea29
@zmoon
Revert "Try to debug why npm build running again in SVG example"
f98295e 
This reverts commit 870ea29.

Seems like the npm build was not there in the docs build.
Probably it built in the cloned repo pyabc2, not the installed one.
@zmoon
Demo build instead of trying to hide it
98c9de9
@zmoon
cov
5438e28
@zmoon
zmoon marked this pull request as ready for review January 17, 2026 05:24
@zmoon
zmoon requested a review from Copilot January 17, 2026 05:24
Copilot AI reviewed Jan 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_html.py Outdated
Comment thread tests/test_html.py
Comment thread pyabc2/sheet/cli.cjs
Comment thread pyabc2/sheet/render.js Outdated
Comment thread pyabc2/html.py
Comment thread pyabc2/html.py Outdated
Comment thread pyabc2/widget/__init__.py
Comment thread pyabc2/sheet/__init__.py
Comment thread pyabc2/widget/__init__.py Outdated
Comment thread tests/test_abcjs_nodejs.py
@zmoon

zmoon commented Jan 17, 2026

Copy link
Copy Markdown
Owner Author

I don't know why codecov is reporting Eskin coverage so low. Those tests are running. Just going to merge for now.

@zmoon
zmoon merged commit 7e1f2f0 into main Jan 17, 2026
8 of 9 checks passed
@zmoon
zmoon deleted the anywidget branch January 17, 2026 05:54
@zmoon zmoon mentioned this pull request Apr 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zmoon