Conversation
tgreenx
requested review from
MichaelTimbert,
marc-vanderwal,
matsduf,
mattias-p and
tolvmannen
September 15, 2026 12:52
tgreenx
added
V-Patch
matsduf
previously approved these changes
Sep 16, 2026
matsduf
reviewed
Sep 16, 2026
matsduf
left a comment
matsduf
left a comment
Contributor
There was a problem hiding this comment.
I suggest that is kept as a ".json" file. Suggestion kindns-profile.json.
Contributor
Author
Well I went with that initially but then I remembered we also support YAML configuration file format (and even provide a working |
Contributor
I do not see the gain of not including ".json". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds the first "preset" profile, in this case related to KINDNS.
Context
Relates to zonemaster/zonemaster#1538
Changes
share/profiles/kindns.jsonHow to test this PR
N/A