ability to get full language tag with unicode extensions - #340
Draft
atlj wants to merge 1 commit into
Draft
Conversation
Author
|
iOS isn't working properly yet. We either need to use this Swift-only API which only works >= iOS 16, or link against the ICU library and forward declare. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
languageTaginside theLocaletype ignores any Unicode extensions despite the documentation saying "Full BCP 47 language tag". This is intended.araborlatn). The numbering system preference affects how APIs likeIntl.NumberFormatterwork.Test Plan
What's required for testing (prerequisites)?
What are the steps to test it (after prerequisites)?
Android
getLocaleshasar-SAaslanguageTagWithExtensionsgetLocaleshasar-SA-u-nu-latn(capitalization is not important) aslanguageTagWithExtensions.iOS
Saudi ArabiagetLocaleshasar-SAaslanguageTagWithExtensions.getLocaleshasar-SA-u-nu-latn(capitalization is not important) aslanguageTagWithExtensions.Compatibility
Checklist
README.mdexample/src/App.js)