CI: sensitivity checks on SBML test suite - #3253
Open
dweindl wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3253 +/- ##
=======================================
Coverage 78.52% 78.53%
=======================================
Files 318 318
Lines 22199 22199
Branches 1490 1491 +1
=======================================
+ Hits 17432 17433 +1
+ Misses 4759 4758 -1
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
fiddy-semantic-checks
branch
from
September 8, 2026 07:45
3da6bd8 to
3d3da23
Compare
This was referenced Sep 8, 2026
dweindl
force-pushed
the
fiddy-semantic-checks
branch
2 times, most recently
from
September 9, 2026 15:25
330b841 to
d06bbcf
Compare
Add fiddy-based finite differences sensitivity checks to the SBML semantic test suite. Splits the single forward-only sensitivity check into three independent nodes per case (forward/adjoint/consistency), generalizes the retry scaffold, fixes cross-test-node model-parameter contamination, and skips known-affected cases (events/piecewise, zero-state models) with adjoint/forward distinguished where relevant. Disables fiddy's function-call caching by default (pure overhead here, source of a flaky CI failure). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dweindl
force-pushed
the
fiddy-semantic-checks
branch
from
September 9, 2026 20:24
7d03ddc to
2d7acd6
Compare
dweindl
marked this pull request as ready for review
September 9, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fiddy-based finite differences sensitivity checks to the SBML semantic test suite for every case with free parameters. fiddy's check_jacobian self-calibrates step sizes/tolerances, so no per-model tuning is needed.
This surfaced pre-existing sensitivity bugs tracked as #3249, #3250 and #3257. Those cases are skipped here for now.
Closes #1236
Closes #2093