Sockets - Shubha - #23
Open
shubha-rajan wants to merge 1 commit into
Open
shubha-rajan wants to merge 1 commit into
shubha-rajan wants to merge 1 commit into
Conversation
|
I wasn't sure on the logic of "!array1" until I read your comment on my pull request. Your code broke down the requirements of the question cleanly, and it is easy for me to read and understand. So great!!! |
jadevance
reviewed
Apr 17, 2019
| if !array1 && !array2 | ||
| return true | ||
| elsif !array1 || !array2 | ||
| return false |
There was a problem hiding this comment.
This is a handy thing to learn when working with logic: https://thepugautomatic.com/2012/09/de-morgans-laws-in-programming/
!(array1 && array2) == (!array1 || !array2) being equivalent means they can be written and convey the same outcomes.
| else | ||
| return false | ||
| end | ||
| return true |
There was a problem hiding this comment.
Nice work on your code! Very clear and easy to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.