Skip to content

Sockets - Shubha #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubha-rajan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Shubha #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError
if !array1 && !array2
return true
elsif !array1 || !array2
return false

@jadevance jadevance Apr 17, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a handy thing to learn when working with logic: https://thepugautomatic.com/2012/09/de-morgans-laws-in-programming/

!(array1 && array2) == (!array1 || !array2) being equivalent means they can be written and convey the same outcomes.

elsif array1.length == array2.length
i = 0
while i < array1.length
return false if array1[i] != array2[i]
i += 1
end
else
return false
end
return true

@jadevance jadevance Apr 17, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on your code! Very clear and easy to read.

end