fix(cli): digest only the compiled persona in a nested agent dir - #318
fix(cli): digest only the compiled persona in a nested agent dir#318willwashburn wants to merge 1 commit into
Conversation
A missing file digests to nulls, so `<agent>/persona.json` alone witnesses both the compile that first writes it and later edits. Digesting the agent subdirectory alongside it invalidated the cached launch plan whenever any sibling changed — the handler, the README, or the `agent-card.json` written by the same compile — rebuilding a plan whose persona was untouched. Also corrects the `sources add --position` wording, which still described a single fixed cwd source. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CLI now fingerprints nested personas by ChangesCLI source and launch behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized CLI and documentation update is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining. Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #316, resolving both review findings.
Launch-plan digest
buildFastLaunchPlandigests one entry per nested agent:<agent>/persona.json. A missing file digests to{size: null, mtimeMs: null}, so that single entry witnesses both the compile that first writes the persona and every later edit to it.The subdirectory digest that sat alongside it was redundant for that, and harmful in its own right: a directory's mtime moves whenever an entry inside is added, removed, or renamed.
agentworkforce persona compilewritesagent-card.jsonnext topersona.json, and editors that save by atomic rename touch the handler and README the same way — each of which rebuilt the cached launch plan for a persona that had not changed.Docs
sources add --position 1ranks a directory after both fixed working-tree sources, not one.🤖 Generated with Claude Code