Skip to content

fix(cli): digest only the compiled persona in a nested agent dir #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willwashburn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): digest only the compiled persona in a nested agent dir #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,13 +406,13 @@ the override without editing JSON by hand.

`sources add` appends by default. `--position <n>` inserts at the 1-based
position among configurable directories, so `--position 1` gives that directory
the highest priority after the fixed cwd source. `sources remove` accepts either
that configurable position or an exact path.
the highest priority after the fixed `cwd` and `cwd:agents` sources. `sources
remove` accepts either that configurable position or an exact path.

Examples:

```sh
# Show the full source cascade, including fixed cwd and library entries
# Show the full source cascade, including fixed cwd/cwd:agents and library entries
agentworkforce sources list

# Install personas from another checkout, below the default user persona dir
Expand Down
9 changes: 5 additions & 4 deletions packages/cli/src/cli-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,10 +1757,11 @@ function buildFastLaunchPlan(input: {
// dirs, so every persona JSON in every layer is a resolution input.
for (const name of entries) {
if (dir.nested) {
// One persona per subdirectory. The subdirectory's own mtime witnesses
// the compile that first creates persona.json, which the parent dir's
// stat does not see.
digests.push(statDigestOf(join(dir.dir, name)));
// One persona per subdirectory. A missing file digests to nulls, so
// this one entry witnesses both the compile that first writes
// persona.json and later edits to it. Digesting the subdirectory too
// would invalidate the plan every time an unrelated sibling — the
// handler, the README, agent-card.json — is added or rewritten.
digests.push(statDigestOf(join(dir.dir, name, NESTED_PERSONA_FILENAME)));
} else if (name.endsWith('.json')) {
digests.push(statDigestOf(join(dir.dir, name)));
Expand Down
Loading