Skip to content

Fix status bar icon contrast in bookmark dialogs - #5617

Open
arpitagarwal1301 wants to merge 1 commit into
Automattic:mainfrom
arpitagarwal1301:fix/2127-status-bar-icon-color
Open

Fix status bar icon contrast in bookmark dialogs#5617
arpitagarwal1301 wants to merge 1 commit into
Automattic:mainfrom
arpitagarwal1301:fix/2127-status-bar-icon-color

Conversation

@arpitagarwal1301

Copy link
Copy Markdown

Description

Fixes the status bar icon contrast when opening Bookmarks from a user file. Light-background themes now use dark status bar icons, while dark-background themes continue using light icons.

Fixes #2127

Testing Instructions

  1. Use a paid account with an uploaded file.
  2. Select a light-background theme.
  3. Open Profile > Files, select a file, and tap Bookmarks.
  4. Verify that the status bar icons are dark and readable.
  5. Repeat with a dark-background theme and verify that the icons remain light.
  6. Dismiss the dialog and verify that the previous status bar appearance is restored.

Screenshots or Screencast

Not included because the affected Cloud File flow requires a paid account with uploaded content.

Checklist

  • Added an entry to CHANGELOG.md.
  • Ran ./gradlew spotlessCheck.
  • Considered automated coverage; the existing unit-test setup does not expose Android system-bar rendering.
  • No strings, Compose UI, analytics schema, or migrations changed.

Validation

  • git diff --check
  • ./gradlew spotlessCheck
  • :modules:features:player:testDebugUnitTest — 77 tests, 0 failures, 0 skipped

@arpitagarwal1301
arpitagarwal1301 requested a review from a team as a code owner July 21, 2026 10:01
@arpitagarwal1301
arpitagarwal1301 requested review from sztomek and removed request for a team July 21, 2026 10:01
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@geekygecko

Copy link
Copy Markdown
Member

Thanks for the contribution. Would you be able to sign the Contributor License Agreement?

@wpmobilebot wpmobilebot modified the milestones: 8.18, 8.19 Aug 3, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

Version 8.18 has now entered code-freeze, so the milestone of this PR has been updated to 8.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Bookmarks [Type] Bug Not functioning as intended.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Status bar icon color is not set correctly for light-themed dialog fragments

4 participants