Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "gasbench"
version = "0.9.9"
version = "0.9.10"
description = "GASBench - ML model benchmark evaluation package"
readme = "README.md"
requires-python = ">=3.10"
Expand Down
2 changes: 2 additions & 0 deletions src/gasbench/dataset/download/cache_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ def _load_dataset_from_cache(dataset, cache_dir: str = "/.cache/gasbench"):
for filename in sample_files:
try:
metadata = sample_metadata.get(filename, {})
# The current registry owns labels; caches may predate a taxonomy change.
metadata = {**metadata, "media_type": dataset.media_type}
filepath = os.path.join(samples_dir, filename)

if dataset.modality == "image":
Expand Down
2 changes: 2 additions & 0 deletions src/gasbench/dataset/iterator.py
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,8 @@ def extract_index(filename):
for filename in sample_items:
file_path = os.path.join(samples_dir, filename)
metadata = metadata_map.get(filename, {})
# The current registry owns labels; caches may predate a taxonomy change.
metadata = {**metadata, "media_type": self.config.media_type}

if self.config.modality == "image":
try:
Expand Down
40 changes: 40 additions & 0 deletions tests/unit/test_cached_sample_labels.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import json

import pytest

from gasbench.constants import media_type_to_label
from gasbench.dataset.config import BenchmarkDatasetConfig
from gasbench.dataset.download.cache_io import _load_dataset_from_cache
from gasbench.dataset.iterator import DatasetIterator


@pytest.mark.parametrize("loader", ["iterator", "download"])
@pytest.mark.parametrize("payload", ["bytes", "frames", "lazy"])
def test_current_video_label_overrides_stale_cache(tmp_path, loader, payload):
config = BenchmarkDatasetConfig(
name="example", path="owner/repo", modality="video", media_type="real",
source_format="mp4", media_per_archive=-1, archives_per_dataset=-1,
)
directory = tmp_path / "datasets" / config.name
samples = directory / "samples"
samples.mkdir(parents=True)
filename = "clip" if payload == "frames" else "clip.mp4"
if payload == "frames":
(samples / filename).mkdir()
(samples / filename / "frame.jpg").write_bytes(b"frame")
else:
(samples / filename).write_bytes(b"video")
(directory / "sample_metadata.json").write_text(json.dumps({filename: {
"media_type": "rendered", "source_file": "original.mp4",
}}))
(directory / "dataset_info.json").write_text("{}")
if loader == "iterator":
iterator = DatasetIterator(config, cache_dir=str(tmp_path), download=False,
lazy_read=payload == "lazy")
result = list(iterator)
else:
result = list(_load_dataset_from_cache(config, str(tmp_path)))
assert len(result) == 1
assert media_type_to_label(result[0]["media_type"], "video") == 0
assert result[0]["source_file"] == "original.mp4"
assert json.loads((directory / "sample_metadata.json").read_text())[filename]["media_type"] == "rendered"
Loading