Verify FFmpeg shared-library downloads before install - #51
Draft
Blackspirits wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FFmpeg video-player shared-library downloader currently uses BtbN's mutable
latestrelease alias and unpacks the downloaded Windows x64 archive without authenticating it.This change:
latestURL with the datedautobuild-2026-09-11-13-20FFmpeg 9.0 buildffmpeg-n9.0.1-29-gad500d59cb-win64-lgpl-shared-9.0.ziplatestalias, tampered cleanup, valid payload acceptance, and missing-digest fail-closed behaviorValidation
BtbN/FFmpeg-Buildsreleaseautobuild-2026-09-11-13-20:40eec25b2f55dcad7e4d4e640919b920d29818b56fdaf9353ce1fd8adefc9d6bFfmpegLibraries.MajorVersionremains9.0, matching the pinned dated asset's release linelatesttag is mutable; the dated asset makes future updates explicit and the pinned digest authenticates the byteslatestalias targetBase is upstream
9be10e12d0f04655f2f134718b00679f89b2b15f.This PR supersedes internal draft #39.
AI assistance: ChatGPT was used to re-audit the FFmpeg shared-library download/install path on current upstream, verify the official BtbN release asset digest, port the minimal integrity fix, and add regression coverage.