Protect multi-stream VOB outputs from accidental overwrite - #66
Draft
Blackspirits wants to merge 1 commit into
Draft
Protect multi-stream VOB outputs from accidental overwrite#66Blackspirits wants to merge 1 commit into
Blackspirits wants to merge 1 commit into
Conversation
Owner
Author
|
Independent adversarial re-check on current upstream base: confirmed the current CLI still preflights only the unnumbered VOB base path while multi-stream extraction writes numbered pairs. The fix computes actual output names after stream discovery and checks every |
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The VOB batch preflight currently protects only the unnumbered base output path. Multi-stream extraction writes numbered pairs such as
movie.0.sub/.idxandmovie.1.sub/.idx, so an existing numbered output can be overwritten even when--overwriteis not supplied.This change:
VobSubExtractor, after the actual subtitle-stream count and output names are known.suband companion.idxfor every resolved output--overwritebehaviorSubtitleConverterCurrent-base verification
fa6d8623c2adb0c646b6d31a11b221b855339bbeSubtitleConverter.cs,VobSubExtractor.cs, andVobSubExtractorTest.csBase is current upstream
fa6d8623c2adb0c646b6d31a11b221b855339bbe.This PR supersedes internal draft #17.
AI assistance: ChatGPT was used to independently re-audit the current VOB multi-stream overwrite path, verify that the affected base files are unchanged from the reviewed draft, port the exact fix onto current upstream, and preserve the focused regressions.