fix(installer): bootstrap with compatible Linux wrappers - #4632
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe release contract now records GNU GLIBC ceilings. Linux installation detects GNU or musl and selects the matching wrapper. A reusable workflow builds, validates, packages, and smoke-tests libc-specific wrappers. ChangesLinux libc compatibility
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🔵 Low · up to The installer now selects GNU or musl Linux wrappers, but release publication still depends on a separate wrapper version bump to publish the matching manifest and artifacts. If that coordination is missed, affected Linux installations can fail until the wrapper release is promoted; the PR is otherwise mergeable with explicit owner follow-up before release. Sequence Diagram(s)sequenceDiagram
participant ReleaseWorkflow
participant WrapperBuilder
participant ABIValidator
participant LibcContainer
participant InstallScript
ReleaseWorkflow->>WrapperBuilder: Pass source_sha and wrapper_version
WrapperBuilder->>WrapperBuilder: Generate matrix and build wrappers
WrapperBuilder->>ABIValidator: Check GLIBC symbols and dynamic dependencies
ABIValidator->>LibcContainer: Select Debian or Alpine image
LibcContainer->>InstallScript: Run offline installer verification
InstallScript->>LibcContainer: Select GNU or musl wrapper
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The changes address issue Full details: Out of Scope Changes checkExplanation The workflow, platform contract, installer, toolchain, and test changes support compatible Linux wrapper publication and selection. The shared cross-installation updates and version pin are related implementation changes. Full details: Docstring CoverageExplanation Docstring coverage is 45.45% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 5 files. (5 skipped: 5 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Binary size checks passed✅ 7 passed
Generated by |
…bookworm-installer # Conflicts: # scripts/tests/test_release_pipeline_contract.py
|
@coderabbitai review |
Fresh review was requested after merging canary, but CodeRabbit did not respond within the requested two-minute window.
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Fixes #4624
We have two structural issues with install.sh/wrapper:
This PR implements three fixes:
HTTPS_PROXYso maybe musl only would be OK, if it ends up being a significant maintenance burdenAd-hoc testing with Debian Bookworm and Alpine on native x86_64 and aarch64 GitHub runners confirms this fix works: