Skip to content

fix: add packaged translation parity check - #2994

Open
rushijagani-dev wants to merge 1 commit into
Chainlit:mainfrom
rushijagani-dev:fix/translation-parity
Open

fix: add packaged translation parity check#2994
rushijagani-dev wants to merge 1 commit into
Chainlit:mainfrom
rushijagani-dev:fix/translation-parity

Conversation

@rushijagani-dev

@rushijagani-dev rushijagani-dev commented Jul 29, 2026

Copy link
Copy Markdown

Summary

  • Add the missing packaged translation keys for ar-SA, da-DK, de-DE, it, ja, and ko.
  • Add a backend regression test that checks every packaged locale JSON file against en-US.json for structural parity.

Fixes #2993

Testing

  • python3 - <<PY ... PY direct packaged translation parity check: all 23 locale files match en-US structure
  • python3 -m ruff check backend/tests/test_translations.py
  • python3 -m ruff format --check backend/tests/test_translations.py
  • git diff --check

Notes

  • uv run pytest backend/tests/test_translations.py could not start locally because uv failed to parse the checked-in uv.lock at line 689 with missing field version.

Summary by cubic

Restore parity across packaged locale JSONs and add a regression test to enforce structure against en-US, fixing missing UI strings and preventing future drift. Fixes #2993.

  • Bug Fixes
    • Filled missing keys: ar-SA/da-DK favorites.remove, ja fileUpload.browse, de-DE/it/ko DatePickerInput placeholders (single, range).
    • Added packaged translations parity test in backend/tests/test_translations.py to compare every locale file to en-US.json.

Written for commit b5f740c. Summary will update on new commits.

Review in cubic

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. backend Pertains to the Python backend. translation Translation or localisation of strings. unit-tests Has unit tests. labels Jul 29, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Pertains to the Python backend. size:XS This PR changes 0-9 lines, ignoring generated files. translation Translation or localisation of strings. unit-tests Has unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: 6 translation keys missing across 6 locales, and nothing enforces parity

1 participant