fix: make stateless members static and internalize app-only types (CA1822, CA1515) - #158
Merged
Merged
Conversation
DeepDiver1975
commented
Aug 30, 2026
Collaborator
- CA1822 (10): AboutViewModel's five display properties are bound from AboutView via {Binding} and must stay instance members — suppressed with justification; IncidentRepository Save/Load/TryReadState and MasterDataStore GetOrCreate/Save were stateless and are now static, with callers (IncidentStore, MasterDataProvider, test suites) updated.
- CA1515 (7): the four desktop App types (AppPaths, IncidentHostController, StorageProviderFileDialogService, SystemAlarmService) are only consumed inside the App assembly plus LageBuch.App.Tests — internalized and granted InternalsVisibleTo for the test project. The test helpers TestAppBuilder, PdfAssert and Domain.Tests FixedClock are internal; xUnit still discovers all tests (801 passed, 1 skipped — unchanged).
- Verification: dotnet build (AnalysisMode=All) shows CA1822 = 0, CA1515 = 0, zero errors, no other rule delta from main; full test suite green.
…1822, CA1515) Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
fix/analyzer-static-internal
branch
from
August 30, 2026 20:46
3a7ea43 to
b366a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.