Skip to content

fix: make stateless members static and internalize app-only types (CA1822, CA1515) - #158

Merged
DeepDiver1975 merged 1 commit into
mainfrom
fix/analyzer-static-internal
Aug 30, 2026
Merged

fix: make stateless members static and internalize app-only types (CA1822, CA1515)#158
DeepDiver1975 merged 1 commit into
mainfrom
fix/analyzer-static-internal

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Collaborator
  • CA1822 (10): AboutViewModel's five display properties are bound from AboutView via {Binding} and must stay instance members — suppressed with justification; IncidentRepository Save/Load/TryReadState and MasterDataStore GetOrCreate/Save were stateless and are now static, with callers (IncidentStore, MasterDataProvider, test suites) updated.
  • CA1515 (7): the four desktop App types (AppPaths, IncidentHostController, StorageProviderFileDialogService, SystemAlarmService) are only consumed inside the App assembly plus LageBuch.App.Tests — internalized and granted InternalsVisibleTo for the test project. The test helpers TestAppBuilder, PdfAssert and Domain.Tests FixedClock are internal; xUnit still discovers all tests (801 passed, 1 skipped — unchanged).
  • Verification: dotnet build (AnalysisMode=All) shows CA1822 = 0, CA1515 = 0, zero errors, no other rule delta from main; full test suite green.

…1822, CA1515)

Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 force-pushed the fix/analyzer-static-internal branch from 3a7ea43 to b366a45 Compare August 30, 2026 20:46
@DeepDiver1975
DeepDiver1975 merged commit 4a1de20 into main Aug 30, 2026
2 checks passed
@DeepDiver1975
DeepDiver1975 deleted the fix/analyzer-static-internal branch August 30, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant