Skip to content

perf: lightweight performance fixes (CA1859, CA1869, CA1308, CA2012, CA1819, CA5392) - #160

Merged
DeepDiver1975 merged 1 commit into
mainfrom
fix/analyzer-perf-minors
Aug 30, 2026
Merged

perf: lightweight performance fixes (CA1859, CA1869, CA1308, CA2012, CA1819, CA5392)#160
DeepDiver1975 merged 1 commit into
mainfrom
fix/analyzer-perf-minors

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Collaborator
  • CA1859 (3): IncidentStore._fileStore typed as IncidentFileStore; AtemschutzTrupp.ValidateCrew takes List (Register already passes members.ToList()); MasterDataStore.SettingsRows returns (string Key, int Value)[] instead of IEnumerable.
  • CA1869 (1): MasterDataJson caches a single static JsonSerializerOptions instead of allocating one per Serialize call.
  • CA1308 (1): FilesViewModel.ContentTypeFor normalizes extension with ToUpperInvariant (arms uppercased).
  • CA2012 (1): MainWindowViewModel awaits ws.LeaveAsync() in the GoHome action instead of discarding the ValueTask (async void lambda, matching the Action-typed event semantics).
  • CA5392 (1): SystemAlarmService.PlaySound gets DefaultDllImportSearchPaths(System32).
  • CA1819 (1): AddFileCommand.Bytes suppressed with justification — byte[] is the wire form System.Text.Json base64-encodes.
  • Verification: AnalysisMode=All harness shows all six rules at 0, zero errors, no other rule delta vs main; full suite 801 passed / 1 skipped (unchanged).

… CA1869, CA1308, CA2012, CA1819, CA5392)

Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 force-pushed the fix/analyzer-perf-minors branch from 2f54692 to dc3dbc9 Compare August 30, 2026 21:07
@DeepDiver1975
DeepDiver1975 merged commit fa61e70 into main Aug 30, 2026
2 checks passed
@DeepDiver1975
DeepDiver1975 deleted the fix/analyzer-perf-minors branch August 30, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant