refactor: get comline-codegen-typescript from ComlineProject/comline-typescript - #20
Merged
Merged
Conversation
…typescript Rollout step 4 follow-up. The typescript generator now lives in its own repo; repoint the dep there (rev 97d8b2e). comline-codegen and comline-codegen-rust align to generation 4f29f4f — the rev comline-typescript pins comline-codegen at — so the tree holds one comline-codegen. No code change. Builds clean; 36 + 2 tests pass; fmt clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollout step 4 follow-up (generation#10).
comline-codegen-typescriptgit dep repoints fromgeneration→comline-typescript(rev97d8b2e).comline-codegen+comline-codegen-rustalign to generation4f29f4f— the revcomline-typescriptpinscomline-codegenat — so the build tree holds onecomline-codegen(and onecomline-core).No code change. Local: builds clean, 36 + 2 tests pass,
cargo fmt --checkclean.Independent of generation#10's merge (pins specific commits).