Repin comline-simulator to the merge SHA - #41
Closed
Kinflou wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Superseded by #42 (Yarn Berry conversion, which folds in this repin). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#40 landed with
comline-simulatorpointing atgit+https://…/simulator.git#feat/prepare-builds-scripted. That branch wasdeleted when simulator#17 merged.
package-lock.jsonpins a SHA so thedeploy still resolves, but the
package.jsonspec is dangling for a coldnpm install.Pins
c3ac42f520a3fca82e996d4b57c1036f9b0eb947(simulatormasterafter#17).
npm test(20) andnpm run buildgreen.