Switch the app from npm to Yarn (Berry 4) - #42
Merged
Conversation
- `.yarnrc.yml` — `nodeLinker: node-modules` (PnP would fight Vite's wasm `?url` + the git-dep deep imports), the committed Yarn 4 release, `approvedGitRepositories` + `enableScripts` so the `comline-simulator` git dep can fetch and run its build, `checksumBehavior: update` because that WASM build isn't byte-reproducible across machines. - `package-lock.json` → `yarn.lock`; scripts use `yarn`; `deploy.yml` runs `yarn install` / `yarn test` / `yarn build` (the runner's Yarn 1.x delegates to `.yarn/releases/`). `yarn test` (20) and `yarn build` pass; the scripted sim wasm still code-splits. Supersedes #41. Repin `comline-simulator` to the simulator#18 merge SHA before this lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/moves off npm to Yarn 4. Folds in thecomline-simulatorrepin that#41 was doing (now closed).
Setup
.yarnrc.ymlnodeLinker: node-modules— PnP would need plugins to satisfy Vite'swasm
?urlimports and thecomline-simulator/pkg-script/…deep imports.approvedGitRepositories+enableScripts: true— Yarn 4 gates git depsand disables lifecycle scripts by default; the sim engine is a git dep
that builds itself in
prepack.checksumBehavior: update— that WASM build isn't byte-reproducible(
wasm-optruns only where installed), so the git-dep tarball checksumdrifts between machines; Yarn refreshes it instead of failing.
.yarn/releases/(the runner'sYarn 1.x delegates to it — no corepack needed).
package-lock.json→yarn.lock;deploy.ymlusesyarn install/yarn test/yarn build.Checks
yarn test(20 view tests) andyarn buildpass; build output keepscomline_simulatoras a split async chunk.Before merging
prepack) merged — Yarn Berry runsprepack, notprepare, for git deps.comline-simulator(package.json+yarn.lock) fromfix/prepack-for-yarnto the feat(sim): the simulate view — canvas, inspector, call form #18 merge SHA.