Labelled column header for the frames pane - #48
Merged
Conversation
Adds a `# DIRECTION KIND FN RTT BYTES` header (+ `CONN` when several connections are logged) above the frame list. The header and every row's `<summary>` now share one grid template (`--frame-grid` / `--frame-grid-conn` on `.sim-frames`), so columns line up; `direction` is sized to content instead of eating the row with `1fr` — the `fn` column takes the slack now, and `rtt` / `bytes` stay right-aligned at the edge.
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #47. The frame rows had no header saying what each column is,
and
directionwasminmax(6rem, 1fr)so it stretched and left a big gapbefore
kind/fn/rtt/bytes.# DIRECTION KIND FN RTT BYTESabove the list (plusCONNwhen more than one connection is logged, matching the row'shas-connvariant).<summary>use one template(
--frame-grid/--frame-grid-conncustom props on.sim-frames), sothey can't drift.
directionis nowminmax(6rem, auto)(content-sized);the
fncolumn takes the1frslack;rttandbytesstayright-aligned at the pane edge.
24 tests + build green.