Frames pane: column rules, table feel - #50
Merged
Conversation
Drop the inter-cell `gap`, move padding onto the cells, and give each cell a `border-right` (last one none) so the header and rows show continuous vertical column rules. `<summary>` hover gets a faint highlight. The grid / cell rules for the header and the rows are merged into shared selectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the frames list read as a proper table.
gapbetween cells is gone, padding moved onto eachcell, and every cell but the last has a
border-right. The header and therows share the same grid + cell styles (merged selectors), so the vertical
lines run continuously from the header down the list.
<summary>:hovergets a faint highlight.idleseparators and refused-connection rows still span full width (theyread as section breaks, which is right).
Kept the CSS-grid layout rather than
<table>markup — the expand-on-click<details>row + full-width detail body doesn't map cleanly to<tr>/<td>, and the grid already aligns exactly. Happy to do thesemantic-table rewrite if you want the actual element.
24 tests + build green.